This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
Refactor hashing #139
Merged
Refactor hashing #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a convenient way of letting the debugging func inject a newline after each write (for readability in debugging).
This separates a bunch of the static state/rules/information that comes from the root project and input parameters into a discrete subsystem. The only real benefit here is focusing the state tracked by the solver in on the actual algorithm of solving, and less so these static rules - which should make it a bit easier for other people to grok.
|
This also makes the hash input dumper delimit each input with newlines, making it FAR easier (read: possible) to diff |
Current coverage is 76.84% (diff: 77.45%)@@ master #139 diff @@
==========================================
Files 24 25 +1
Lines 3694 3735 +41
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2852 2870 +18
- Misses 635 658 +23
Partials 207 207
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nominally in pursuit of #125, but actually ends up doing a bunch more Good Things™, too.