This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
Commits on Jan 12, 2017
-
Use an io.Writer to write hashing inputs
This provides a convenient way of letting the debugging func inject a newline after each write (for readability in debugging).
Configuration menu - View commit details
-
Copy full SHA for 6109ef1 - Browse repository at this point
Copy the full SHA 6109ef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2488c3e - Browse repository at this point
Copy the full SHA 2488c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c24a4 - Browse repository at this point
Copy the full SHA 95c24a4View commit details -
Split out 'rootdata' struct from solver
This separates a bunch of the static state/rules/information that comes from the root project and input parameters into a discrete subsystem. The only real benefit here is focusing the state tracked by the solver in on the actual algorithm of solving, and less so these static rules - which should make it a bit easier for other people to grok.
Configuration menu - View commit details
-
Copy full SHA for 53a999a - Browse repository at this point
Copy the full SHA 53a999aView commit details
Commits on Jan 14, 2017
-
Comprehensive refactor of input hashing rules
All changes are geared towards making "default"-type values explicit, as that increases the likelihood that equivalent inputs will produce identical hash digests.
Configuration menu - View commit details
-
Copy full SHA for 28ed699 - Browse repository at this point
Copy the full SHA 28ed699View commit details -
tabwriter system for visualizing hash inputs diffs
Hashing functions are exquisitely sensitive to inputs - that's why they're useful. But it makes them a PITA to work with. Having an easy-to-scan visualization of hashing inputs in tests frees up cognitive capacity to focus on the algorithm.
Configuration menu - View commit details
-
Copy full SHA for 870a6ca - Browse repository at this point
Copy the full SHA 870a6caView commit details
Commits on Jan 15, 2017
-
Section headers in hash inputs; tests refactor
To further improve debugging of issues with the input hashing, this adds "section headers" - strings that are output prior to each type of data that's present in the cache. Also partially switched to progressive mutation table-based tests for input hashing, and added test cases that cover salient combinations of overrides, imports, and constraints.
Configuration menu - View commit details
-
Copy full SHA for 5799cd8 - Browse repository at this point
Copy the full SHA 5799cd8View commit details -
Add diff-ish indicators to hash diff output
Makes it easier to see problem spots on a quick scan.
Configuration menu - View commit details
-
Copy full SHA for 0a9c6c6 - Browse repository at this point
Copy the full SHA 0a9c6c6View commit details -
Add funcs for typed constraint string output
These solve the problem, at least in the hasher, of the possibility for strings representing different types of versions to collide. For example, prior to this change, a branch constraint named "foo" and a version constraint named "foo" could cause the hasher to produce the same hash, even though the two inputs would not have admitted the same solution set.
Configuration menu - View commit details
-
Copy full SHA for 1b37f02 - Browse repository at this point
Copy the full SHA 1b37f02View commit details -
Configuration menu - View commit details
-
Copy full SHA for d441d82 - Browse repository at this point
Copy the full SHA d441d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85a0fc3 - Browse repository at this point
Copy the full SHA 85a0fc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 366fea2 - Browse repository at this point
Copy the full SHA 366fea2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.