fix: nearest_n_within does not limit num of items when not sorted #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 95.30% 95.42% +0.11%
==========================================
Files 52 52
Lines 7583 7650 +67
Branches 7583 7650 +67
==========================================
+ Hits 7227 7300 +73
+ Misses 335 329 -6
Partials 21 21 ☔ View full report in Codecov by Sentry. |
sdd
force-pushed
the
fix-nearest-n-unsorted-bug
branch
from
1399d6e to
a1cc36f
Compare
sdd
force-pushed
the
fix-nearest-n-unsorted-bug
branch
from
a1cc36f to
936ed24
Compare
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #168