Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

restyling proposition #78

Merged
merged 6 commits into from
Jan 31, 2024
Merged

restyling proposition #78

merged 6 commits into from
Jan 31, 2024

Conversation

SvMak
Copy link

@SvMak SvMak commented Jan 27, 2024

Hello. I would like to suggest a small restyling of the site to freshen it up and make it a bit more modern, would appreciate feedback.

Thanks.

@marc0der
Copy link
Member

marc0der commented Jan 28, 2024

Hey @SvMak,

Firstly, I just want to say that I'm completely blown away by your awesome work and that I simply love, love, love it! Thanks so much for all the effort you've put into this. I can't thank you enough.

If you don't mind, I have one or two tiny tweaks that I would ask, but overall, the effect is fantastic. Shall we take it offline on the community Slack?

Cheers,
Marco.

@SvMak
Copy link
Author

SvMak commented Jan 28, 2024

Hello, thank you!
Of course you can make suggestions for changes.

@hgeraldino
Copy link

For what is worth, I left this comment on the slack channel, let me know what you think:

looks pretty cool.. I think the only thing I’d change is probably the contributors section, which occupies >50% of the landing page

maybe a carousel/slider (with a link to a page that shows the full list of contributors would be better?

@marc0der
Copy link
Member

This is all looking great, thank you. I also noticed that the contributors don't link to their corresponding open collective pages. Is that something that we can do?

Another thing was that the carbon ad is taking up an entire row and is off to the right side. I'm wondering if we can move it up to the spot where it was in the top right corner where it felt more out of the way. This isn't super important though.

@SvMak
Copy link
Author

SvMak commented Jan 31, 2024

You can check fixes. If you have other suggestions, let me know.

@marc0der
Copy link
Member

This is fantastic. And again, thank you so much for everything. It looks great.

@marc0der marc0der merged commit c2282b7 into sdkman:master Jan 31, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants