-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct ACE463 Photos #162
Conversation
Please only suggest/make any changes to the following files:
All other files are generated from this file using the .github/workflows/create_db_derivatives.yaml GitHub action, and if you do not make your changes there, they will be overwritten and lost. |
@rickstaa It looks like this pull request was incorrectly tagged with the |
@rickstaa I see why. As the derivative files were also updated, *.csv files, it got the second tag. |
Well I can't find where to add an approval tag but it looks good to me |
well, it seems if you add additional commits to an existing pull request, the invalid label is applied? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the approve thing 🎉
So is the 'correct' way of doing this to create a new branch in our own forks and merge those individually? I'm just used to committing everything to the main branch. I have no idea how to do a different fork in VSCode 😩 |
@dziban303 no, you and @Phaeton were using the correct way. The problems were caused by different line endings between Linux and Windows. I now changed the action 👍🏻. |
Merged in #163. |
Describe your changes
Correct ACE463 Photos that are currently incorrect
Checklist before requesting a review