Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q4 additions #197

Closed
wants to merge 5 commits into from
Closed

Q4 additions #197

wants to merge 5 commits into from

Conversation

dziban303
Copy link
Collaborator

Describe your changes

Added MQ-4C Tritons and NATO RQ-4D Phoenixes. Corrected N1DC category to match others in that category (and fix grammar).

Sources include Mictronics and VRS databases; verified reg numbers with publicly available imagery

Checklist before requesting a review

  • I have performed a self-review of my code.
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers.

@github-actions github-actions bot added the planes Plane info label Apr 2, 2023
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Please only suggest/make any changes to the following files:

All other files are generated from this file using the .github/workflows/create_db_derivatives.yaml GitHub action, and if you do not make your changes there, they will be overwritten and lost.

@Phaeton
Copy link
Collaborator

Phaeton commented Apr 2, 2023

On N1DC, it was originally submitted the way you are changing it to, see #72, but the “‘“ and “?” were removed in #76. Not sure if those characters are problematic or not.

@dziban303
Copy link
Collaborator Author

dziban303 commented Apr 2, 2023 via email

@@ -3326,7 +3326,7 @@ C0010A,C-FAKF,Private,AutoGyro Europe Cavalon,CLON,Civ,Little Nellie,Gyrocopter,
A77B6F,N581UP,United Parcel Service,Boeing 747,B744,Civ,You Came Here In That Thing,Flying Rust Bucket,Nope Mobile,You came here in that thing ?,https://www.ups.com/gb/en/Home.page,https://cdn.jetphotos.com/full/6/74080_1544118780.jpg,https://live.staticflickr.com/65535/50151135247_ef519a9b35_k.jpg,https://cdn.jetphotos.com/full/6/34385_1608084982.jpg,https://cdn.jetphotos.com/full/5/45573_1640102913.jpg
A3026F,N293UP,United Parcel Service,MD-11,MD11,Civ,You Came Here In That Thing,Flying Rust Bucket,Nope Mobile,You came here in that thing ?,https://www.ups.com/gb/en/Home.page,https://cdn.jetphotos.com/full/5/54556_1632687851.jpg,https://cdn.jetphotos.com/full/5/18400_1626314320.jpg,https://cdn.jetphotos.com/full/6/20447_1626092111.jpg,
406E4D,G-CIRH,Willy Rose Technology,Magni Gyro M-16 Tandem Trainer,MM16,Civ,Little Nellie,Gyrocopter,Nope Mobile,You came here in that thing ?,http://www.magnigyro.it/en/products/m24-orion,https://cdn.jetphotos.com/full/6/31460_1627740788.jpg,https://cdn.jetphotos.com/full/5/76393_1553808913.jpg,,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,Americas Team,Dont you know who I am,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,

@@ -3326,7 +3326,7 @@ C0010A,C-FAKF,Private,AutoGyro Europe Cavalon,CLON,Civ,Little Nellie,Gyrocopter,
A77B6F,N581UP,United Parcel Service,Boeing 747,B744,Civ,You Came Here In That Thing,Flying Rust Bucket,Nope Mobile,You came here in that thing ?,https://www.ups.com/gb/en/Home.page
A3026F,N293UP,United Parcel Service,MD-11,MD11,Civ,You Came Here In That Thing,Flying Rust Bucket,Nope Mobile,You came here in that thing ?,https://www.ups.com/gb/en/Home.page
406E4D,G-CIRH,Willy Rose Technology,Magni Gyro M-16 Tandem Trainer,MM16,Civ,Little Nellie,Gyrocopter,Nope Mobile,You came here in that thing ?,http://www.magnigyro.it/en/products/m24-orion
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,Americas Team,Dont you know who I am,https://en.wikipedia.org/wiki/Dallas_Cowboys
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am?,https://en.wikipedia.org/wiki/Dallas_Cowboys

@@ -12865,7 +12876,7 @@ A3026F,N293UP,United Parcel Service,MD-11,MD11,Civ,You Came Here In That Thing,F
48050D,F-014,Royal Netherlands Air Force,F35 Lightning II,F35,Mil,Foutje Bedankt,Fighter,Hash House Harrier,Zoomies,https://www.defensie.nl/organisatie/luchtmacht,https://cdn.jetphotos.com/full/6/85572_1634050351.jpg,https://cdn.jetphotos.com/full/5/67193_1619313290.jpg,https://cdn.jetphotos.com/full/5/32889_1614585753.jpg,
48050A,F-011,Royal Netherlands Air Force,F35 Lightning II,F35,Mil,Foutje Bedankt,Fighter,Hash House Harrier,Zoomies,https://www.defensie.nl/organisatie/luchtmacht,https://live.staticflickr.com/65535/51121229894_60081f69fb_b.jpg,https://live.staticflickr.com/65535/50305201952_6a22e4cb2e_h.jpg,https://cdn.jetphotos.com/full/5/36926_1599220933.jpg,
AF351F,13-5067,USAF,F35 Lightning II,F35,Mil,Foutje Bedankt,Fighter,To Fly Fight And Win,Zoomies,https://www.airforce.com,https://cdn.jetphotos.com/full/5/22736_1527487152.jpg,https://cdn.jetphotos.com/full/5/29473_1502704225.jpg,https://cdn.jetphotos.com/full/6/96948_1478052178.jpg,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,Americas Team,Dont you know who I am,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
Suggested change
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am?,https://en.wikipedia.org/wiki/Dallas_Cowboys,https://cdn.jetphotos.com/full/5/59473_1599220751.jpg,,,

@@ -12865,7 +12876,7 @@ A3026F,N293UP,United Parcel Service,MD-11,MD11,Civ,You Came Here In That Thing,F
48050D,F-014,Royal Netherlands Air Force,F35 Lightning II,F35,Mil,Foutje Bedankt,Fighter,Hash House Harrier,Zoomies,https://www.defensie.nl/organisatie/luchtmacht
48050A,F-011,Royal Netherlands Air Force,F35 Lightning II,F35,Mil,Foutje Bedankt,Fighter,Hash House Harrier,Zoomies,https://www.defensie.nl/organisatie/luchtmacht
AF351F,13-5067,USAF,F35 Lightning II,F35,Mil,Foutje Bedankt,Fighter,To Fly Fight And Win,Zoomies,https://www.airforce.com
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,Americas Team,Dont you know who I am,https://en.wikipedia.org/wiki/Dallas_Cowboys
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am ?,https://en.wikipedia.org/wiki/Dallas_Cowboys
A00050,N1DC,Jerry Jones,Gulfstream G-V,GLF5,Civ,NFL,The Other Football,America's Team,Don't you know who I am?,https://en.wikipedia.org/wiki/Dallas_Cowboys

Copy link
Collaborator

@Phaeton Phaeton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I suggested one minor edit to remove an extra space in N1DC.

@dziban303
Copy link
Collaborator Author

dziban303 commented Apr 4, 2023

As I said in my earlier reply, the space is in all of the entries of that category. It's also in nearly 100 entries of the category 'You came here in that thing ?'

Output from xsv frequency -l 0 -s Category plane-alert-db.csv:

Category,You came here in that thing ?,98
...
Category,Don't you know who I am ?,17

So if the space was removed from one, it should be removed from them all.

@github-actions github-actions bot added the invalid This doesn't seem right label Apr 4, 2023
@dziban303
Copy link
Collaborator Author

dziban303 commented Apr 4, 2023

All instances of blah blah ? now changed to blah blah?

Ah and of course the automatic stuff failed, chef's kiss

@dziban303 dziban303 closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right planes Plane info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants