Update RuboCop #818
Merged
Update RuboCop #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Jan 10, 2024
| @@ -11,7 +11,7 @@ gem 'rspec', '~> 3.0' | |||
| gem 'simplecov', '~> 0.21.0' | |||
| gem 'simplecov-lcov', '~> 0.8.0' | |||
|
|
|||
| # Pin RuboCop for Travis builds. | |||
| gem 'rubocop', '0.82.0' | |||
| # Pin RuboCop for CI builds | |||
There was a problem hiding this comment.
Changed since it looks like Travis is no longer used.
andyw8
commented
Jan 10, 2024
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| context 'when phpcs fixer exits successfully with fixed file' do | |||
| before do | |||
| # rubocop:disable Metrics/LineLength | |||
| # rubocop:disable Layout/LineLength | |||
There was a problem hiding this comment.
RuboCop has changed the category of this cop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of Ruby is from April 2020. Since there are quite a lot of new issues identified, I've committed them to the
.rubocop_todo.ymlso that they can be addressed incrementally or disabled.