Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get suite running smoothly again #824

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Get suite running smoothly again #824

merged 5 commits into from
Feb 24, 2024

Conversation

benmelz
Copy link
Contributor

@benmelz benmelz commented Feb 22, 2024

Am planning on proposing/implementing a new feature, but first I noticed that there are a number of failing specs on main, so I figured I would start with that.

As written, this includes four main adjustments, two of which might actually be bugfixes:

  • one spec was hanging indefinitely for me locally on a Thread.join call - explicitly capturing the child threads and joining them directly fixed it (might be machine dependent?)
  • when an encoding is specified, the rails schema up to date hook was passing arguments incorrectly (kwarg containing encoding was being interpreted as the length positional arg) (possible bug)
  • many specs were attempting to create file submodules without the protocol.file.allow=always config option causing failure
  • alias detection for amendment appeared to be broken, due to regexp incompatibilities between ruby/git (git wasn't properly parsing \s in the value matcher for git config --regexp [key] [value] command), so moved that matching into ruby (possible bug, also maybe machine/git build opt dependent)
  • dropped ruby 2.6 from the test matrix - it appears that it's far enough EOL that github has trouble even setting it up. I can attempt to add it back/get it working, but I figured it might be time to ditch it

*I don't have a windows machine, so I'm not gonna be much help with those CI builds (should note fails appear unrelated to anything I've done here).

Copy link
Owner

@sds sds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@sds sds merged commit 607ce05 into sds:main Feb 24, 2024
6 of 8 checks passed
@sds
Copy link
Owner

sds commented Feb 24, 2024

Would be open to dropping support for Ruby 2.7, given it's also EoL (but if we have tests passing, fine to keep).

sds added a commit that referenced this pull request Feb 24, 2024
This reverts commit 607ce05.

Going to try to merge a different branch.
sds added a commit that referenced this pull request Feb 24, 2024
This reverts commit 607ce05.

Going to try to merge a different branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants