Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am planning on proposing/implementing a new feature, but first I noticed that there are a number of failing specs on main, so I figured I would start with that.
As written, this includes four main adjustments, two of which might actually be bugfixes:
Thread.join
call - explicitly capturing the child threads and joining them directly fixed it (might be machine dependent?)encoding
was being interpreted as thelength
positional arg) (possible bug)protocol.file.allow=always
config option causing failure\s
in the value matcher forgit config --regexp [key] [value]
command), so moved that matching into ruby (possible bug, also maybe machine/git build opt dependent)*I don't have a windows machine, so I'm not gonna be much help with those CI builds (should note fails appear unrelated to anything I've done here).