Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to use sass v3.5.4 #934

Closed
wants to merge 1 commit into from
Closed

Avoid to use sass v3.5.4 #934

wants to merge 1 commit into from

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Jan 5, 2018

Some test cases fail with sass v3.5.4, and the test does snot fail in v3.5.5.

with sass 3.5.3

$ bundle exec rspec
...
1764 examples, 0 failures

with sass 3.5.4

$ bundle exec rspec
...
1764 examples, 117 failures

with sass 3.5.5

$ bundle exec rspec
...
1764 examples, 0 failures

I guess it is sass gem's bug. So I think scss-lint should avoid sass v3.5.4.

Some test cases fail with sass v3.5.4, and the test does snot fail in v3.5.5.

with sass 3.5.3
----

```
$ bundle exec rspec
...
1764 examples, 0 failures
```

with sass 3.5.4
----

```
$ bundle exec rspec
...
1764 examples, 117 failures
```

with sass 3.5.4
----

```
$ bundle exec rspec
...
1764 examples, 0 failures
```

----

I guess it is sass gem's bug. So I think scss-lint should avoid sass v3.5.4.
@tagliala tagliala mentioned this pull request Jan 8, 2018
@tagliala
Copy link
Contributor

tagliala commented Jan 8, 2018

Hi @pocke , yes that was a Sass regression fixed in 3.5.5 (ref: sass/sass#2423)

I've just opened a PR which includes #933 and #934.

Please note that I don't want to take credits of your work here, I'm working on that PR from a long while

Ref:
#927 (comment)
#927 (comment)

@sds
Copy link
Owner

sds commented Jan 9, 2018

Implemented in #935. Thanks!

@sds sds closed this Jan 9, 2018
@pocke pocke deleted the avoid-sass-3.5.4 branch January 9, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants