-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cff): doi structure parsing #121
Conversation
…output RDF of authors
Adds citation file (cff) to gimie repository for documenation and testing purposes.
…ure. Update pyshacl, comment out useless pyshacl test throwing errors
duplicate check
Co-authored-by: Cyril Matthey-Doret <cyril.matthey-doret@epfl.ch>
Co-authored-by: Cyril Matthey-Doret <cyril.matthey-doret@epfl.ch>
Co-authored-by: Cyril Matthey-Doret <cyril.matthey-doret@epfl.ch>
Only commit 4f5ef97 onwards is actually new/relevant. Soz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions and comment to make sure that this is the desired behavior, but in principle it's good 👍
Thanks for your good points! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to reduce nesting, but besides that it looks good to merge. 🙌
But please squash commits when merging this PR
Co-authored-by: Cyril Matthey-Doret <cyril.matthey-doret@epfl.ch>
Thank you for the nesting tip - looking at your change it does make sense. I was under the impression that the nesting didn't matter - if my first also: |
The DOI in a CFF is wrapped in an identifier object like so:
Our script was looking for doi objects like this:
doi: 10.5281/zenodo.3555620
Only the first case is a valid CFF format, so we must iterate through the identifier's, pick only the ones that are typed as doi, and return the value.