Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs website #58

Merged
merged 43 commits into from
Jun 9, 2023
Merged

Docs website #58

merged 43 commits into from
Jun 9, 2023

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Jun 7, 2023

This PR adds a documentation website. The website is built with sphinx and deployed on github pages at https://sdsc-ord.github.io/gimie.
A CI pipeline deploys the documentation to the gh-pages branch on every new commit to main.

The website contains a few introduction pages and tutorials subject to change. A documentation for the python API and the command line interface is generated automatically on every new build, using the sphinx extension autodoc, and sphinx-click, respectively.

Documentation can be built locally by running make doc. It is built in the doc/_build directory.

cmdoret added 26 commits May 25, 2023 11:20
@cmdoret cmdoret added the documentation Improvements or additions to documentation label Jun 7, 2023
@cmdoret cmdoret requested review from sabinem and vancauwe June 7, 2023 17:13
@cmdoret cmdoret self-assigned this Jun 7, 2023
@cmdoret cmdoret requested review from rmfranken and removed request for vancauwe June 8, 2023 11:16
@cmdoret cmdoret linked an issue Jun 8, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@rmfranken rmfranken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking what "Review changes" means when I press this button. I added some comments, but will add more tomorrow.

docs/intro/tokens.rst Outdated Show resolved Hide resolved
gimie/cli.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders a bit strange, you get a header "gimie" and then the text "Command line group".

After that, it shows two code-snippets with the exact same code, with no information on what this actually means/does. I think it could be ommited for clarity, or explained.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very worth it to spend a lot of time, so very optional thing to do if someone feels bored.

docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
Copy link
Member

@rmfranken rmfranken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tres bien

@cmdoret cmdoret merged commit 59b1a4a into main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gimie] Docs website
2 participants