fix: NOASSERTION should not return triples. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdoret
approved these changes
Aug 31, 2023
|
Tracked in #67, feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Github API is a bit picky with licenses, it sometimes return "NOASSERTION" as the value of a license. This happens when it has found "something" licenselike, but cannot match it exactly to a spdx license. In that case, we don't want it to return a triple
:someObject schema:license <spdx.org/NOASSERTION> since that doesn't actually exist. Instead, it should not return any triple for license.
I solved it a bit brutely with a string check for the licenseInfo, but it's simple, as long as spdx does not suddenly introduce a license called "NOASSERTION".