Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: license matcher for git extractor #78

Merged
merged 16 commits into from
Oct 17, 2023
Merged

feature: license matcher for git extractor #78

merged 16 commits into from
Oct 17, 2023

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Oct 16, 2023

This PR adds support for local license detection on the Git extractor. Thus enabling it for git providers other than github and gitlab.
It also simplifies the license matching code and moves some boilerplate common across extractors to the abstract class.

@cmdoret cmdoret requested a review from rmfranken October 16, 2023 14:11
@cmdoret cmdoret self-assigned this Oct 16, 2023
Copy link
Member

@rmfranken rmfranken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okidoki happy to have seen you code it, made it a lot easier to go through this.

gimie/sources/git.py Outdated Show resolved Hide resolved
gimie/sources/common/license.py Outdated Show resolved Hide resolved
gimie/sources/common/license.py Outdated Show resolved Hide resolved
@cmdoret cmdoret linked an issue Oct 17, 2023 that may be closed by this pull request
4 tasks
@cmdoret cmdoret merged commit 57ff0c8 into main Oct 17, 2023
6 checks passed
@rmfranken
Copy link
Member

giphy

@cmdoret cmdoret deleted the feat/license-git branch November 10, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement license detection for GitExtractor
2 participants