Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new instr_type that directly aggregates runtime per region/region interaction #738

Merged
merged 8 commits into from
Mar 17, 2023

Conversation

bnico99
Copy link
Contributor

@bnico99 bnico99 commented Jan 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Patch coverage: 48.38% and project coverage change: -0.08 ⚠️

Comparison is base (0ad512d) 66.95% compared to head (6057d63) 66.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##           vara-dev     #738      +/-   ##
============================================
- Coverage     66.95%   66.88%   -0.08%     
============================================
  Files           322      324       +2     
  Lines         24227    24320      +93     
============================================
+ Hits          16221    16266      +45     
- Misses         8006     8054      +48     
Impacted Files Coverage Δ
varats/varats/tools/bb_config.py 100.00% <ø> (ø)
...data/reports/performance_influence_trace_report.py 47.05% <47.05%> (ø)
...riments/vara/agg_region_interaction_perf_runner.py 50.00% <50.00%> (ø)
...rats/varats/experiments/vara/feature_experiment.py 41.13% <100.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bnico99 bnico99 changed the title Experimental: Directly aggregate runtime per region/region interaction Add new instr_type that directly aggregates runtime per region/region interaction Feb 6, 2023
@bnico99 bnico99 marked this pull request as ready for review February 6, 2023 14:10
Copy link
Contributor

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but we should wait to integrate this until the instrumentation are merged.

Copy link
Member

@boehmseb boehmseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

But what's up with mypy here?

@vulder vulder merged commit 9ff72b7 into vara-dev Mar 17, 2023
@vulder vulder deleted the f-RegionReport branch March 17, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants