-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new instr_type that directly aggregates runtime per region/region interaction #738
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #738 +/- ##
============================================
- Coverage 66.95% 66.88% -0.08%
============================================
Files 322 324 +2
Lines 24227 24320 +93
============================================
+ Hits 16221 16266 +45
- Misses 8006 8054 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but we should wait to integrate this until the instrumentation are merged.
varats/varats/experiments/vara/agg_region_interaction_perf_runner.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
But what's up with mypy here?
No description provided.