Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix compatibility with libressl (macos) and openssl 1.1.1k #66

Merged
merged 9 commits into from
Jan 4, 2022

Conversation

q9f
Copy link
Collaborator

@q9f q9f commented Nov 11, 2021

attempt to address #47 by applying @raggi 's work at bitcoin-ruby#311

cc @zeptonaut - I would agree though using a proper ruby/openssl implementation should be the greater goal.

@q9f
Copy link
Collaborator Author

q9f commented Nov 11, 2021

abort trap: 6 indicates issues with libssl; please confirm

@justinsoong
Copy link

@q9f i've tried using your branch to load the gem, and the abort trap is still happening (macOS, 11.6)

ruby is loading libcrypto in an unsafe way

@q9f
Copy link
Collaborator Author

q9f commented Nov 17, 2021

I guess I need to get a mac then :S

@justinsoong
Copy link

@q9f this is an interesting thread: cl-plus-ssl/cl-plus-ssl#114

@justinsoong
Copy link

@q9f it worked after i did this

sudo ln -s /usr/local/Cellar/openssl@1.1/1.1.1k/lib/libssl.1.1.dylib /usr/local/lib/libssl.dylib
sudo ln -s /usr/local/Cellar/openssl@1.1/1.1.1k/lib/libcrypto.1.1.dylib /usr/local/lib/libcrypto.dylib

@justinsoong
Copy link

@q9f this might be interesting money-tree is a dep and is loading openssl in the old way also causing issues, merge is waiting though: GemHQ/money-tree#43

@q9f
Copy link
Collaborator Author

q9f commented Nov 24, 2021

I got myself a mac and the issue is indeed money-tree. I'm trying to reach out to them.

@wink
Copy link

wink commented Nov 24, 2021

I hear you guys loud and clear. money-tree hasn't been actively maintained for a while. Monkey patching OpenSSL was the only solution I had at the time to perform the proper calculations. It wasn't intended to stay in there for so many years. I'm going to chat with @q9f after Thanksgiving about maintaining it.

@justinsoong
Copy link

justinsoong commented Nov 26, 2021

@wink @q9f 👍 🙏 Thank you for your efforts! Looking forward to contributing! Good news is that the MoneyTree calcs are only in two places :)

@raggi
Copy link

raggi commented Nov 26, 2021

I'm cc'd into this due to my fixing a related library. If a maintainer/patch author would like some help solving for the local problems feel free to reach out to me with some details and I'll be happy to provide some advice.

@q9f
Copy link
Collaborator Author

q9f commented Nov 26, 2021

I'm cc'd into this due to my fixing a related library. If a maintainer/patch author would like some help solving for the local problems feel free to reach out to me with some details and I'll be happy to provide some advice.

Thank you for your comment. Historically, the eth gem inherited the openssl code from the bitcoin gem. I applied your patch (thank you, btw 🙏🏼) and it fixes the aforementioned issues. Now we just have the money-tree dependency that also has this issue. But hopefully, we'll be able to address this soon with @wink after Thanksgiving. :)

@jake
Copy link

jake commented Dec 9, 2021

thanks for getting this sorted! what all is left to get this released? I'm working on a project where this would be very helpful and just wondering if it'd work in my timeline.

@q9f
Copy link
Collaborator Author

q9f commented Dec 9, 2021

Hi Jake, just waiting for the money tree release so that I can bump the dependency.

GemHQ/money-tree#50

mabdullahkhalil and others added 2 commits January 4, 2022 14:15
* gems: bump keccak to 1.3.0 (#69)

* Gems: bump version to 0.4.17 (#70)

* Gems: bump version to 0.4.17

* docs: update changelog

* Dependancy money tree changed

* Adding Money tree dependanccy

* mabdullahlkhalil/gemdependacies

* Gem dependanct

* Gem dependanct

* Gem dependacy

* mabdullahlkhalil/gemdependacies

* Gem dependacy

* Money Tree fix

* Update eth.gemspec

* Update eth.gemspec
@q9f q9f merged commit 0f2629e into develop Jan 4, 2022
@q9f q9f deleted the q9f/eth/openssl branch January 4, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants