Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simulation tests for RISCVVIRT32 #234

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Nov 10, 2022

This is a follow-up on #209 to also add support for the 32-bit version of qemu-riscv-virt. It's currently still in draft state, as building fail for me locally. However, that might not be a blocker to add it to the action already, so it can be used once the issues are fixed.

see also: seL4/seL4#951

@axel-h axel-h force-pushed the patch-axel-7 branch 3 times, most recently from cc1c508 to 390a7c6 Compare November 13, 2022 01:59
@axel-h axel-h marked this pull request as ready for review November 15, 2022 13:01
@axel-h axel-h requested a review from lsf37 as a code owner November 15, 2022 13:01
@lsf37
Copy link
Member

lsf37 commented Nov 15, 2022

This looks fine from my side, but it will be part of the build matrix for simulation immediately when we merge it (unless we filter it out specifically), so we should make sure first that the build work.

One way to not have it in the build matrix immediately (for simulation) would be to comment out the simulation_binary line. With that the disabled and no_hw_build flags are strong enough.

@axel-h
Copy link
Member Author

axel-h commented Nov 15, 2022

The build still fails locally for me due to a non-trivial issue. But I lack time to investigate it, so please don't merge. Will make it a draft again.

@axel-h axel-h marked this pull request as draft November 15, 2022 22:20
@axel-h axel-h force-pushed the patch-axel-7 branch 3 times, most recently from 61bd681 to 9bfe45a Compare November 18, 2022 15:24
@lsf37 lsf37 changed the title add RISCVVIRT32 add simulation tests for RISCVVIRT32 Oct 24, 2023
@axel-h axel-h marked this pull request as ready for review October 24, 2023 14:15
Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
@axel-h
Copy link
Member Author

axel-h commented Oct 24, 2023

@Ivan-Velickovic Ivan-Velickovic merged commit 2a5f3a0 into seL4:master Oct 24, 2023
6 of 7 checks passed
@axel-h axel-h deleted the patch-axel-7 branch October 24, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants