-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std feature, impl std::error::Error #22
Conversation
@seanmonstar Are you waiting to publish a new version or did you forget again? ;P |
Something tickles me weird about having the |
It's a common convention, I made it a default so it didn't break any existing usage expecting it to work with |
@seanmonstar Would you prefer to leave the
|
Ignore me, it's perfect. Thanks! |
The convention is to have a feature named Using this convention is not a breaking change, since no httparse versions that use no_std have been published yet. |
@jethrogb so, have this instead: [features]
default = ["std"]
std = [] And anyone wanting to use it in a |
If that seems correct, I've made a PR to do that, and I can release the new version today #23 |
No description provided.