Add ability to clear cookies from a CookieStore
#1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this issue still open? I also need to clear cookies |
Adds method `clear(&self)` to trait `cookies::CookieStore`, allowing users to clear a store's contents. Adds method `clear_cookies(&self)` to `Client` under feature `cookies`.
|
The original change here is breaking, as it has been labelled (and I did not keep on top of for inclusion in last breaking release...). I've rebased the existing PR for current In the meantime, you can use something like reqwest_cookie_store which gives you more direct access to the underlying store, which does expose a clear() method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #613 for a simple "batteries included" quality-of-life improvement.
Adds method
clear(&self)to traitcookies::CookieStore, allowingusers to clear a store's contents.
Adds method
clear_cookies(&self)toClientunder featurecookies.Alternatively, instead of adding this to the
cookies::CookieStoretrait and expanding theClientAPI, thecookies::Jarimpl could be extended with the requested method directly. However, this does not seem to be as "batteries included" for users that simply want to utilize the defaultJarviaClientBuilder::cookie_store(true).