chore: A few simple cleanups/lints #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I asked clippy to help out, to see if any simple improvements are available. I ignored most of the pedantic ones, but a few of them seemed reasonable. * in a few places, the match with `_` is used, even though there is only one other option. I think it is better to explicitly list them all - so that if another enum value is added in the future, it won't compile until someone looks at each case and decides what should the proper value be. This way there won't be any surprising breakages due to changes in the enums. * a few `use wildcard` inlinings * some big numbers are easier to read with underscores * `for` iterating without `.iter()`
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Aug 22, 2023
Bumps reqwest from 0.11.18 to 0.11.19.
Release notes
Sourced from reqwest's releases.
v0.11.19
What's Changed
Add ClientBuilder::http1_ignore_invalid_headers_in_responses() option.
Add ClientBuilder::http1_allow_spaces_after_header_name_in_responses() option.
Add support for ALL_PROXY environment variable.
Add support for use_preconfigured_tls when combined with HTTP/3.
Fix deflate decompression from using the zlib decoder.
Fix Response::{text, text_with_charset}() to strip BOM characters.
Fix a panic when HTTP/3 is used if UDP isn't able to connect.
Fix some dependencies for HTTP/3.
Increase MSRV to 1.63.
New Contributors
@nyurik made their first contribution in seanmonstar/reqwest#1849
@smndtrl made their first contribution in seanmonstar/reqwest#1856
@attila-lin made their first contribution in seanmonstar/reqwest#1869
@ollyswanson made their first contribution in seanmonstar/reqwest#1898
@VivekPanyam made their first contribution in seanmonstar/reqwest#1903
@bouzuya made their first contribution in seanmonstar/reqwest#1922
@cipherbrain made their first contribution in seanmonstar/reqwest#1927
@T-Sujeeban made their first contribution in seanmonstar/reqwest#1926
@eric-seppanen made their first contribution in seanmonstar/reqwest#1852
Changelog
Sourced from reqwest's changelog.
v0.11.19
Add ClientBuilder::http1_ignore_invalid_headers_in_responses() option.
Add ClientBuilder::http1_allow_spaces_after_header_name_in_responses() option.
Add support for ALL_PROXY environment variable.
Add support for use_preconfigured_tls when combined with HTTP/3.
Fix deflate decompression from using the zlib decoder.
Fix Response::{text, text_with_charset}() to strip BOM characters.
Fix a panic when HTTP/3 is used if UDP isn't able to connect.
Fix some dependencies for HTTP/3.
Increase MSRV to 1.63.
Commits
8b49fc9 v0.11.19
87ff5d9 improve error message if incompabitle Identity with selected backend (#1852)
42f57b4 Fix panic in building h3 client when udp is forbidden (#1945)
4aa8516 msrv: bump to 1.63 (#1947)
1f6c2cf Add ClientBuilder::http1_allow_spaces_after_header_name_in_responses() (#1932)
6f07b9f Add ClientBuilder::http1_ignore_invalid_headers_in_responses() (#1926)
8396233 Fix deflate decompression (#1927)
b0c07a2 Bump rustls to v0.21.6 (#1928)
99bbae6 Bump webpki-roots to v0.25 (#1922)
61b1b2b Bump wasm-streams dependency to 0.3 (#1903)
Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked clippy to help out, to see if any simple improvements are available. I ignored most of the pedantic ones, but a few of them seemed reasonable.
_is used, even though there is only one other option. I think it is better to explicitly list them all - so that if another enum value is added in the future, it won't compile until someone looks at each case and decides what should the proper value be. This way there won't be any surprising breakages due to changes in the enums.use wildcardinliningsforiterating without.iter()