Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd support #1866

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add zstd support #1866

merged 1 commit into from
Apr 15, 2024

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Jun 3, 2023

This PR has been recreated after I accidentally deleted my fork for #1464

Closes #1463

@ozgrakkurt
Copy link

This would be very useful indeed

@paolobarbolini paolobarbolini force-pushed the zstd branch 2 times, most recently from 5375c5e to 9beb47d Compare November 7, 2023 11:17
@tafia
Copy link
Contributor

tafia commented Nov 29, 2023

Is there any news / blocking point?

@paolobarbolini
Copy link
Contributor Author

Is there any news / blocking point?

No blockers on my part. I too wish we could get feedback on this PR, especially considering that lately there has been some progress with zstd on the web https://caniuse.com/zstd

@paolobarbolini
Copy link
Contributor Author

It looks like Chromium may be close to shipping it 1. I'd be happy to rebase after the hyper v1 upgrade @seanmonstar.

Footnotes

  1. https://chromestatus.com/feature/6186023867908096

@seanmonstar
Copy link
Owner

Thanks for pushing on this for so long. I remember looking a while ago, and it seemed to be unhappy on Windows. Assuming it works fine now, I'd be happy to merge.

@paolobarbolini
Copy link
Contributor Author

Yeah zstd had a Windows issue some time ago, it's been fixed upstream. I think this is ready for merging.

@seanmonstar seanmonstar merged commit 1073881 into seanmonstar:master Apr 15, 2024
34 checks passed
@seanmonstar
Copy link
Owner

Thanks again! I delayed merging a little bit just in case there was major problems with v0.12 that I'd need to revert or handle. But seems like its pretty smooth now. So this will go out in the next release.

Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Content-Encoding: zstd
4 participants