-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zstd support #1866
Add zstd support #1866
Conversation
990ab27
to
7ba30e0
Compare
This would be very useful indeed |
5375c5e
to
9beb47d
Compare
Is there any news / blocking point? |
No blockers on my part. I too wish we could get feedback on this PR, especially considering that lately there has been some progress with zstd on the web https://caniuse.com/zstd |
It looks like Chromium may be close to shipping it 1. I'd be happy to rebase after the hyper v1 upgrade @seanmonstar. Footnotes |
Thanks for pushing on this for so long. I remember looking a while ago, and it seemed to be unhappy on Windows. Assuming it works fine now, I'd be happy to merge. |
Yeah zstd had a Windows issue some time ago, it's been fixed upstream. I think this is ready for merging. |
Thanks again! I delayed merging a little bit just in case there was major problems with v0.12 that I'd need to revert or handle. But seems like its pretty smooth now. So this will go out in the next release. |
This PR has been recreated after I accidentally deleted my fork for #1464
Closes #1463