-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for SOCKS4 (#610) #2400
Conversation
Added a simple example here to test that everything works as expected: https://github.com/Jaltaire/reqwest/blob/examples/examples/socks4.rs. We can merge this too, if desired. |
Also added a bump of tokio-socks to 0.5.2 since 0.5.2 makes SOCKS4 implementation feature-complete: https://github.com/sticnarf/tokio-socks/releases/tag/v0.5.2. |
@seanmonstar Would you mind taking a look at this? |
b0dd83b
to
e67902f
Compare
Thanks for working on this! Looks good, I'll start CI :) |
My pleasure. :) @seanmonstar, I just re-pushed with the cargo fmt fixes. Would you mind re-running the CI? |
This doesn't seem to be related to my changes from what I can tell... Running @seanmonstar How would you like to handle this? Can we bump to |
I'll take care of it in #2412 |
@seanmonstar Just rebased off your change. Can you kick off CI again? |
@seanmonstar, many thanks for helping get this through today. |
This adds support for SOCKS4 proxies, implementing #610.