-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poll inner connection until EOF after gzip decoder is complete #2484
Poll inner connection until EOF after gzip decoder is complete #2484
Conversation
…inated and to not rely on implementation details of async-compression
Should I expand the fix on all other decompression methods? |
If they all have the same characteristic, namely that they know they ended before reading EOF, then they probably all suffer from the same thing. |
Should I add tests for all other decompression methods? |
You can. If so, I'd do with a for loop, or some pattern to reduce the duplicate parts. |
Can reqwest deal with such cases (multiple compression algorithms)?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding |
I don't think it can, but not a single person has filed saying they needed it. So I suspect that is more of a theoretical part of the spec, and not something that servers ever actually do. So I wouldn't bother supporting it for now, it'd make things complicated and we don't seem to need it. |
I don't know why it fails style check, |
Some code doesn't get formatted automatically because of conditional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, excellent, excellent work. Thanks so much for cleaning this up! <3
Fix for #2381