Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: translate over response headers #689

Merged
merged 1 commit into from
Oct 21, 2019
Merged

wasm: translate over response headers #689

merged 1 commit into from
Oct 21, 2019

Conversation

paolobarbolini
Copy link
Contributor

Closes #656

@seanmonstar
Copy link
Owner

Thanks for helping out on WASM support!

Is using serde the recommended way to translate from JsValue like this? I would have thought there was something built-in that didn't need serde...

@paolobarbolini
Copy link
Contributor Author

From what I've seen currently the only wasm-bindgen built in way of doing it is to use serde_json rustwasm/wasm-bindgen#1258.
There's an alternative to serde_json that leverages the native JavaScript APIs: https://github.com/cloudflare/serde-wasm-bindgen.

Since we'll also have to implement json Serialization and Deserialization for the json methods, whatever library we decide for this should also be used for everything else.

@seanmonstar seanmonstar merged commit dd65fc7 into seanmonstar:master Oct 21, 2019
@seanmonstar
Copy link
Owner

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM: translate over response headers
2 participants
@paolobarbolini @seanmonstar