Merge pull request #222 from nitram509/replace-stringbuilder-with-str…

…ing-concatenation Replace StringBuilder with String concatenation, as suggested by IntelliJ
searchbox-io · Jul 12, 2015 · 715627c · 715627c
2 parents 40d71d6 + 7b3f9ad
commit 715627c
Show file tree

Hide file tree

Showing 37 changed files with 43 additions and 117 deletions.
diff --git a/jest-common/src/main/java/io/searchbox/cluster/GetSettings.java b/jest-common/src/main/java/io/searchbox/cluster/GetSettings.java
@@ -16,9 +16,7 @@ protected GetSettings(Builder builder) {
     }
 
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_cluster/settings");
-        return sb.toString();
+        return super.buildURI() + "/_cluster/settings";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/Health.java b/jest-common/src/main/java/io/searchbox/cluster/Health.java
@@ -16,9 +16,7 @@ protected Health(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_cluster/health/");
-        return sb.toString();
+        return super.buildURI() + "/_cluster/health/";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/NodesHotThreads.java b/jest-common/src/main/java/io/searchbox/cluster/NodesHotThreads.java
@@ -20,11 +20,9 @@ protected NodesHotThreads(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_nodes/")
-                .append(nodes)
-                .append("/hot_threads");
-        return sb.toString();
+        return super.buildURI() + "/_nodes/" +
+                nodes +
+                "/hot_threads";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/NodesInfo.java b/jest-common/src/main/java/io/searchbox/cluster/NodesInfo.java
@@ -16,9 +16,7 @@ protected NodesInfo(Builder builder) {
     }
 
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_nodes").append("/").append(nodes);
-        return sb.toString();
+        return super.buildURI() + "/_nodes/" + nodes;
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/NodesShutdown.java b/jest-common/src/main/java/io/searchbox/cluster/NodesShutdown.java
@@ -17,11 +17,9 @@ protected NodesShutdown(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_nodes/")
-                .append(nodes)
-                .append("/_shutdown");
-        return sb.toString();
+        return super.buildURI() + "/_nodes/" +
+                nodes +
+                "/_shutdown";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/NodesStats.java b/jest-common/src/main/java/io/searchbox/cluster/NodesStats.java
@@ -17,11 +17,9 @@ protected NodesStats(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_nodes/")
-                .append(nodes)
-                .append("/stats");
-        return sb.toString();
+        return super.buildURI() + "/_nodes/" +
+                nodes +
+                "/stats";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/State.java b/jest-common/src/main/java/io/searchbox/cluster/State.java
@@ -16,9 +16,7 @@ protected State(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_cluster/state");
-        return sb.toString();
+        return super.buildURI() + "/_cluster/state";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/cluster/UpdateSettings.java b/jest-common/src/main/java/io/searchbox/cluster/UpdateSettings.java
@@ -25,9 +25,7 @@ protected UpdateSettings(Builder builder) {
     }
 
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_cluster/settings");
-        return sb.toString();
+        return super.buildURI() + "/_cluster/settings";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Bulk.java b/jest-common/src/main/java/io/searchbox/core/Bulk.java
@@ -117,9 +117,7 @@ public String getPathToResult() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_bulk");
-        return sb.toString();
+        return super.buildURI() + "/_bulk";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Count.java b/jest-common/src/main/java/io/searchbox/core/Count.java
@@ -21,9 +21,7 @@ protected Count(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_count");
-        return sb.toString();
+        return super.buildURI() + "/_count";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/DeleteByQuery.java b/jest-common/src/main/java/io/searchbox/core/DeleteByQuery.java
@@ -20,9 +20,7 @@ protected DeleteByQuery(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_query");
-        return sb.toString();
+        return super.buildURI() + "/_query";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Explain.java b/jest-common/src/main/java/io/searchbox/core/Explain.java
@@ -23,9 +23,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_explain");
-        return sb.toString();
+        return super.buildURI() + "/_explain";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/MoreLikeThis.java b/jest-common/src/main/java/io/searchbox/core/MoreLikeThis.java
@@ -19,9 +19,7 @@ protected MoreLikeThis(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_mlt");
-        return sb.toString();
+        return super.buildURI() + "/_mlt";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/MultiGet.java b/jest-common/src/main/java/io/searchbox/core/MultiGet.java
@@ -46,9 +46,7 @@ public Object apply(Doc doc) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_mget");
-        return sb.toString();
+        return super.buildURI() + "/_mget";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/MultiSearch.java b/jest-common/src/main/java/io/searchbox/core/MultiSearch.java
@@ -55,9 +55,7 @@ public String getData(Gson gson) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_msearch");
-        return sb.toString();
+        return super.buildURI() + "/_msearch";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Percolate.java b/jest-common/src/main/java/io/searchbox/core/Percolate.java
@@ -28,9 +28,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_percolate");
-        return sb.toString();
+        return super.buildURI() + "/_percolate";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Search.java b/jest-common/src/main/java/io/searchbox/core/Search.java
@@ -43,9 +43,7 @@ public String getType() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_search");
-        return sb.toString();
+        return super.buildURI() + "/_search";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/SearchScroll.java b/jest-common/src/main/java/io/searchbox/core/SearchScroll.java
@@ -30,9 +30,7 @@ protected SearchScroll(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_search/scroll");
-        return sb.toString();
+        return super.buildURI() + "/_search/scroll";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/SearchShards.java b/jest-common/src/main/java/io/searchbox/core/SearchShards.java
@@ -18,9 +18,7 @@ protected SearchShards(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_search_shards");
-        return sb.toString();
+        return super.buildURI() + "/_search_shards";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Suggest.java b/jest-common/src/main/java/io/searchbox/core/Suggest.java
@@ -35,9 +35,7 @@ public String getType() {
 
     @Override
     protected String buildURI() {
-        final StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_suggest");
-        return sb.toString();
+        return super.buildURI() + "/_suggest";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Update.java b/jest-common/src/main/java/io/searchbox/core/Update.java
@@ -26,9 +26,7 @@ public String getBulkMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_update");
-        return sb.toString();
+        return super.buildURI() + "/_update";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/core/Validate.java b/jest-common/src/main/java/io/searchbox/core/Validate.java
@@ -21,9 +21,7 @@ protected Validate(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder(super.buildURI());
-        sb.append("/_validate/query");
-        return sb.toString();
+        return super.buildURI() + "/_validate/query";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/Analyze.java b/jest-common/src/main/java/io/searchbox/indices/Analyze.java
@@ -23,9 +23,7 @@ protected Analyze(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_analyze");
-        return sb.toString();
+        return super.buildURI() + "/_analyze";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/ClearCache.java b/jest-common/src/main/java/io/searchbox/indices/ClearCache.java
@@ -16,9 +16,7 @@ protected ClearCache(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_cache/clear");
-        return sb.toString();
+        return super.buildURI() + "/_cache/clear";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/CloseIndex.java b/jest-common/src/main/java/io/searchbox/indices/CloseIndex.java
@@ -16,9 +16,7 @@ protected CloseIndex(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_close");
-        return sb.toString();
+        return super.buildURI() + "/_close";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/Flush.java b/jest-common/src/main/java/io/searchbox/indices/Flush.java
@@ -16,9 +16,7 @@ protected Flush(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_flush");
-        return sb.toString();
+        return super.buildURI() + "/_flush";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/OpenIndex.java b/jest-common/src/main/java/io/searchbox/indices/OpenIndex.java
@@ -15,9 +15,7 @@ protected OpenIndex(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_open");
-        return sb.toString();
+        return super.buildURI() + "/_open";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/Optimize.java b/jest-common/src/main/java/io/searchbox/indices/Optimize.java
@@ -21,9 +21,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_optimize");
-        return sb.toString();
+        return super.buildURI() + "/_optimize";
     }
 
     public static class Builder extends AbstractMultiIndexActionBuilder<Optimize, Builder> {

diff --git a/jest-common/src/main/java/io/searchbox/indices/Refresh.java b/jest-common/src/main/java/io/searchbox/indices/Refresh.java
@@ -21,9 +21,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_refresh");
-        return sb.toString();
+        return super.buildURI() + "/_refresh";
     }
 
     public static class Builder extends AbstractMultiIndexActionBuilder<Refresh, Builder> {

diff --git a/jest-common/src/main/java/io/searchbox/indices/Stats.java b/jest-common/src/main/java/io/searchbox/indices/Stats.java
@@ -25,9 +25,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_stats");
-        return sb.toString();
+        return super.buildURI() + "/_stats";
     }
 
     public static class Builder extends AbstractMultiIndexActionBuilder<Stats, Builder> {

diff --git a/jest-common/src/main/java/io/searchbox/indices/Status.java b/jest-common/src/main/java/io/searchbox/indices/Status.java
@@ -22,9 +22,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_status");
-        return sb.toString();
+        return super.buildURI() + "/_status";
     }
 
     public static class Builder extends AbstractMultiIndexActionBuilder<Status, Builder> {

diff --git a/jest-common/src/main/java/io/searchbox/indices/aliases/GetAliases.java b/jest-common/src/main/java/io/searchbox/indices/aliases/GetAliases.java
@@ -20,9 +20,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_aliases");
-        return sb.toString();
+        return super.buildURI() + "/_aliases";
     }
 
     public static class Builder extends AbstractMultiIndexActionBuilder<GetAliases, Builder> {

diff --git a/jest-common/src/main/java/io/searchbox/indices/aliases/ModifyAliases.java b/jest-common/src/main/java/io/searchbox/indices/aliases/ModifyAliases.java
@@ -28,9 +28,7 @@ protected ModifyAliases(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_aliases");
-        return sb.toString();
+        return super.buildURI() + "/_aliases";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/mapping/DeleteMapping.java b/jest-common/src/main/java/io/searchbox/indices/mapping/DeleteMapping.java
@@ -19,9 +19,7 @@ protected DeleteMapping(Builder builder) {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_mapping");
-        return sb.toString();
+        return super.buildURI() + "/_mapping";
     }
 
     @Override

diff --git a/jest-common/src/main/java/io/searchbox/indices/mapping/GetMapping.java b/jest-common/src/main/java/io/searchbox/indices/mapping/GetMapping.java
@@ -21,9 +21,7 @@ public String getRestMethodName() {
 
     @Override
     protected String buildURI() {
-        StringBuilder sb = new StringBuilder();
-        sb.append(super.buildURI()).append("/_mapping");
-        return sb.toString();
+        return super.buildURI() + "/_mapping";
     }
 
     public static class Builder extends AbstractMultiTypeActionBuilder<GetMapping, Builder> {