Issue #127, JSON in alias filter is unnecessarily escaped. Changed Strin...

[igor-kupczynski]

Example solution to Isuse #127: Changed String to JsonObject in AliasMapping actions.

[coveralls]

Changes Unknown when pulling 9aca3ed on puszczyk:Issue#127 into * on searchbox-io:master*.

[kramer]

All looks great except the AliasFilters class which I believe does not really fit the code style of the project (utility class for test data).

[igor-kupczynski]

Agree, I haven't seen other cases like this in the tests. What is the preferred approach though? Copy-paste into the test classes or to have a common superclass with the content as a field? Or something else maybe?

[kramer]

Copy pasting would be the preferred approach for tests, as (imho) using base/utility classes for test purposes mostly decreases readability and any gain from them can be ignored since the purpose is testing.

[igor-kupczynski]

OK, I've changed the code. Please take a look :-)

[coveralls]

Changes Unknown when pulling ca39394 on puszczyk:Issue#127 into * on searchbox-io:master*.