-
Notifications
You must be signed in to change notification settings - Fork 727
Added action for adding and deleting indexed scripts #213
Conversation
@@ -69,6 +69,11 @@ | |||
</dependency> | |||
|
|||
<dependency> | |||
<groupId>org.easytesting</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertions used (contains/null/equals) really fall short of justifying the need for this additional library as we already have junit. Let's stick with junit for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kramer
fest assertions works nicely together with JUnit and Hamcrest.
It offers a readable fluent API and meaningful assertion messages (if tests fails).
May I ask why stick with junit and not extending the possibilities of assertions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nothing against fest I'm sure its as awesome as jest if not more 😄.
Main reason is consistency; having two test classes with a different assert syntax than the rest of the project is just awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
I will rework to use JUnit instead of fest.
Also please feel free to add yourself to thanks section in readme :) |
…re consistence to all other tests
reworked to use AbstractAction.CHARSET, to be more consistent
@kramer Would you please have a look at. Regards |
Just two very minor things:
|
Fixed :-) |
Added actions for adding and deleting indexed scripts
Thank you for your contribution @nitram509 ! |
I would like to add two more actions.
One adds indexed scripts, the other deletes them.
As a basis, I've used the reference at:
https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-scripting.html
Feedback is welcome.
Regards
Martin