Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial badge component #1004

Merged
merged 31 commits into from
May 16, 2024
Merged

feat: initial badge component #1004

merged 31 commits into from
May 16, 2024

Conversation

dkonieczek
Copy link
Contributor

No description provided.

@dkonieczek dkonieczek linked an issue Feb 16, 2024 that may be closed by this pull request
Badges Container Component #987
Closed
@dkonieczek dkonieczek marked this pull request as ready for review February 29, 2024 16:49
@dkonieczek dkonieczek requested a review from korgon February 29, 2024 16:49
@dkonieczek
Copy link
Contributor Author

dkonieczek commented Mar 25, 2024 •
edited
Loading

Group review feedback:

  • remove bages from root store -> move to having result.badges be an object and get badges from there
  • fix demo store css when callout text badge with long text

korgon
korgon requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Need to add a few tests and implement priority logic.

packages/snap-client/src/Client/transforms/searchResponse.ts Show resolved Hide resolved
packages/snap-client/src/Client/transforms/searchResponse.ts Outdated Show resolved Hide resolved
packages/snap-preact-components/src/components/Molecules/CalloutBadge/CalloutBadge.stories.tsx Outdated Show resolved Hide resolved
packages/snap-preact-components/src/components/Molecules/CalloutBadge/readme.md Outdated Show resolved Hide resolved
packages/snap-preact-components/src/components/Molecules/OverlayBadge/OverlayBadge.stories.tsx Outdated Show resolved Hide resolved
packages/snap-shared/src/MockData/meta/8uyt2m/meta.json Outdated Show resolved Hide resolved
packages/snap-store-mobx/src/Meta/MetaStore.ts Show resolved Hide resolved
packages/snap-store-mobx/src/types.ts Outdated Show resolved Hide resolved
packages/snap-store-mobx/src/Search/Stores/SearchResultStore.ts Show resolved Hide resolved
@dkonieczek dkonieczek requested a review from korgon April 3, 2024 21:22
korgon
korgon requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things...

packages/snap-store-mobx/src/Search/Stores/SearchResultStore.ts Outdated Show resolved Hide resolved
packages/snap-store-mobx/src/Search/Stores/SearchResultStore.ts Outdated Show resolved Hide resolved
packages/snap-store-mobx/src/Meta/MetaStore.ts Outdated Show resolved Hide resolved
@dkonieczek dkonieczek requested a review from korgon April 4, 2024 19:24
chrisFrazier77
chrisFrazier77 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@chrisFrazier77 chrisFrazier77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the old badge component. going to be confusing having both

@korgon korgon merged commit 79c499f into develop May 16, 2024
1 check passed
@korgon korgon deleted the badges branch May 16, 2024 21:21
@korgon korgon mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisFrazier77 chrisFrazier77 chrisFrazier77 left review comments

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badges Container Component
3 participants
@dkonieczek @korgon @chrisFrazier77