Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform Badges Bugfix #1230

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Transform Badges Bugfix #1230

merged 2 commits into from
Dec 19, 2024

Conversation

chrisFrazier77
Copy link
Contributor

bugfix in transformSearchResponse transforming badge fields

@chrisFrazier77 chrisFrazier77 linked an issue Dec 18, 2024 that may be closed by this pull request
Badges Bug #1219
Closed
korgon
korgon reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test additions.

packages/snap-client/src/Client/transforms/searchResponse.ts Outdated Show resolved Hide resolved
packages/snap-client/src/Client/transforms/searchResponse.ts Outdated Show resolved Hide resolved
@korgon korgon merged commit 68962c7 into develop Dec 19, 2024
1 check passed
@korgon korgon deleted the badges-bugfix branch December 19, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badges Bug
2 participants
@chrisFrazier77 @korgon