-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundleRecommendations component #965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ming bundlerecs feature
This was
linked to
issues
Dec 19, 2023
Closed
korgon
requested changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress on this!
packages/snap-controller/src/Recommendation/RecommendationController.ts
Outdated
Show resolved
Hide resolved
packages/snap-controller/src/Recommendation/RecommendationController.ts
Outdated
Show resolved
Hide resolved
packages/snap-preact-components/src/components/Molecules/Carousel/Carousel.tsx
Outdated
Show resolved
Hide resolved
packages/snap-preact-components/src/components/Molecules/Carousel/Carousel.tsx
Outdated
Show resolved
Hide resolved
...preact-components/src/components/Organisms/BundledRecommendations/BundledRecommendations.tsx
Outdated
Show resolved
Hide resolved
...preact-components/src/components/Organisms/BundledRecommendations/BundledRecommendations.tsx
Outdated
Show resolved
Hide resolved
packages/snap-preact-demo/src/components/Recommendations/Recs/Recs.tsx
Outdated
Show resolved
Hide resolved
...preact-components/src/components/Organisms/BundledRecommendations/BundledRecommendations.tsx
Outdated
Show resolved
Hide resolved
…gfixes to bundledRecommendation
korgon
requested changes
Jan 3, 2024
packages/snap-preact-components/src/components/Organisms/BundledRecommendation/BundleCTA.tsx
Outdated
Show resolved
Hide resolved
...p-preact-components/src/components/Organisms/BundledRecommendation/BundledRecommendation.tsx
Outdated
Show resolved
Hide resolved
packages/snap-preact-components/src/components/Organisms/BundledRecommendation/BundleCTA.tsx
Outdated
Show resolved
Hide resolved
...p-preact-components/src/components/Organisms/BundledRecommendation/BundledRecommendation.tsx
Outdated
Show resolved
Hide resolved
korgon
requested changes
Jan 3, 2024
packages/snap-controller/src/Recommendation/RecommendationController.ts
Outdated
Show resolved
Hide resolved
korgon
previously approved these changes
Jan 3, 2024
Converted to draft to prevent accidental merging. |
…ting for swiper upgrade
cypress component testing for swiper upgrade
Bundled variants
…s running and passing again
…testing around cta and variants
…ds compatability with swiper
swiper v11 upgrade
…d onnext functions for swiper
… for default nav containers
…e for hideCheckboxes in story
korgon
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new component for upcoming bundlerecs feature