Update error checking #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the master branch, instances which return an error message and nothing are erronously seen as a valid. This is fixed. For "Search response time": * Some instances return results only from the wiki* engines: this commit expect at least one result of a generic engine (not a wiki* engine). * 5 requests are sent instead of 3 The sort algorithm was not pushing back the instances with errors (no result). This is fixed.
dalf
commented
Sep 23, 2023
|
|
||
|
|
||
| CheckResultByTheme = { | ||
| 'simple': CheckResult( | ||
| results=etree.XPath("//div[@id='urls']//article"), | ||
| engines=etree.XPath("//div[contains(@class, 'engines')]/span"), | ||
| engines=etree.XPath(".//div[contains(@class, 'engines')]/span"), |
There was a problem hiding this comment.
Before this commit, the list of engine names were per page instead of per result as expected.
dalf
commented
Sep 23, 2023
| print(search_url, '(', theme, ')') | ||
| check_result = CheckResultByTheme[theme] | ||
| default_params = {'theme': theme} | ||
| default_params = {'theme': 'simple'} |
There was a problem hiding this comment.
Since all instances are SearXNG forks, we can safely keep only the simple theme.
dalf
commented
Sep 23, 2023
| } | ||
|
|
||
| const CompareFunctionCriterias = { | ||
| 'http.status_code': (a, b) => -compareTool(a, b, null, 'http', 'status_code'), | ||
| 'error': (a, b) => -compareTool(a, b, null, 'error'), | ||
| 'error_wp': (a, b) => compareTool(a, b, null, 'timing', 'search_wp', 'error'), |
There was a problem hiding this comment.
Since a long time, there is no more test on the wikipedia engine : remove dead code.
unixfox
approved these changes
Sep 23, 2023
|
Good for merging thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the master branch, instances which return an error message and nothing are erroneously seen as a valid. This is fixed.
For the "Search response time" column:
The sort algorithm was not pushing back the instances with errors (no result). This is fixed.