Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just temporary Rework doc #136

Closed
wants to merge 9 commits into from
Closed

Just temporary Rework doc #136

wants to merge 9 commits into from

Conversation

querdenker2k
Copy link
Collaborator

sorry don't get it to commit to your branch

@querdenker2k querdenker2k marked this pull request as draft February 20, 2023 21:00
@seaside1
Copy link
Owner

Builds for me locally. Fails first time if I remove the docker images.

@querdenker2k
Copy link
Collaborator Author

@seime @seaside1 finally it was the latest commit, which fixed it: 4e31dd9
I would suggest that you just put it in your documentation branch or should i create a new one for this?

@seaside1
Copy link
Owner

@querdenker2k Nice find!
I have added the fix in #135 , waiting to see if it builds correctly

@seaside1
Copy link
Owner

Closing this PR, since #135 built successfully

@seaside1 seaside1 closed this Feb 22, 2023
@querdenker2k querdenker2k deleted the rework_doc branch February 23, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@querdenker2k @seaside1 @seime