Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add previousState and a test #168

Merged
merged 3 commits into from
Sep 7, 2023
Merged

add previousState and a test #168

merged 3 commits into from
Sep 7, 2023

Conversation

querdenker2k
Copy link
Collaborator

adds previousState persistence function

@querdenker2k querdenker2k requested a review from seime August 21, 2023 15:28
@querdenker2k querdenker2k marked this pull request as ready for review August 21, 2023 15:28
@seaside1
Copy link
Owner

Will review shortly and come back

seime
seime reviewed Sep 2, 2023
View reviewed changes
Copy link
Collaborator

@seime seime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in pom.xml, will they affect logging during unit tests? Why commented out and not removed (in case not needed anymore)?

@querdenker2k
Copy link
Collaborator Author

First it was just a test. It's not needed anymore, this is already included by the parent pom.
Added some more logging in Exception cases for better seeing the cause.

@seaside1
Copy link
Owner

seaside1 commented Sep 6, 2023

Soon was not as soon as I had hoped. Got stuck when I had the incorrect openhab-core.jar as dependency, so had to revisit and update #115

I'll see if I can test on my live system soon.

/S

seaside1
seaside1 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@seaside1 seaside1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested this with both mapdb and influx.
We should add an Example for this as well in the documentation.

@seaside1 seaside1 merged commit 38b343a into seaside1:main Sep 7, 2023
@querdenker2k querdenker2k deleted the add-previousState branch September 30, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seime seime seime left review comments

@seaside1 seaside1 seaside1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@querdenker2k @seaside1 @seime