Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for InvocationTargetException the get stacktrace has changed from get… #188

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

querdenker2k
Copy link
Collaborator

for InvocationTargetException the get stacktrace has changed from getTargetException() to getCause()
I changed the jdk from zulu to temurin and my stacktraces are lost. getTargetException() just gives me the exception message, not the stacktrace anymore.
With the new implementation the caused by it logged twice now. I am afraid to remove the \ntarget: {} part that in some cases the caused by stacktrace isn't printed anymore in some jdk versions.

@seaside1
Copy link
Owner

I agree, lets try it out, we can always change later if needed.

Copy link
Owner

@seaside1 seaside1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@seaside1 seaside1 merged commit 5a38824 into seaside1:main Feb 16, 2024
1 check passed
@querdenker2k querdenker2k deleted the log-invocation-target branch February 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants