Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Actions (openhab internal), rename old Actions to ThingActions #208

Conversation

querdenker2k
Copy link
Collaborator

This PR will

  • rename generated JRuleActions to JRuleThingActions
  • generate JRuleActions (based on all found ActionService's, e.g. Notifications from openhabcloud)

@seime
Copy link
Collaborator

seime commented Oct 24, 2024

At first glance, is it related to #204?

@querdenker2k
Copy link
Collaborator Author

oh damn, looks like. i saw your merge request, but never opened it and couldn't imagine what that meant based on the title.
The approach is slightly different.
I used ActionService and you used ActionType.
Your's is still in progress? Can i try it?

@seime
Copy link
Collaborator

seime commented Oct 25, 2024

I forgot a bit about the pr myself, but I've been running it in production since this summer without issues. Ready for testing.

Not sure which approach is best, I'll need to read the code again to freshen my memory 😅.

@jberggg
Copy link

jberggg commented Oct 31, 2024

I'm running @seime 's changes for broadcast notifications through openhab "cloud". It works 👍🏽 Would be awesome if that feature makes it into the main branch. Thank you both for your work 🙏🏽

@seime
Copy link
Collaborator

seime commented Dec 26, 2024

@querdenker2k should we merge this or the other PR and get the functionality out to everyone?

@querdenker2k
Copy link
Collaborator Author

If yours is working we can take yours (and because some more people used this in production). I used mine not productive because of the problem that the iphone app does not support two service instances like the android app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants