Cloning readonly properties does not work in PHP 8.2

sebastianbergmann · Apr 9, 2024 · 5af0410 · 5af0410
1 parent 20c1475
commit 5af0410
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/src/Framework/MockObject/Runtime/Api/DoubledCloneMethod.php b/src/Framework/MockObject/Runtime/Api/DoubledCloneMethod.php
@@ -9,13 +9,26 @@
  */
 namespace PHPUnit\Framework\MockObject;
 
+use function version_compare;
+use PHPUnit\Event\Code\TestMethodBuilder;
+use PHPUnit\Event\Facade as EventFacade;
+
 /**
  * @internal This trait is not covered by the backward compatibility promise for PHPUnit
  */
 trait DoubledCloneMethod
 {
     public function __clone(): void
     {
+        if (version_compare('8.3.0', PHP_VERSION, '>')) {
+            EventFacade::emitter()->testTriggeredPhpunitError(
+                TestMethodBuilder::fromCallStack(),
+                'Cloning test double objects requires PHP 8.3',
+            );
+
+            return;
+        }
+
         $this->__phpunit_state = clone $this->__phpunit_state;
 
         $this->__phpunit_state()->cloneInvocationHandler();

diff --git a/src/Framework/MockObject/Runtime/Api/ProxiedCloneMethod.php b/src/Framework/MockObject/Runtime/Api/ProxiedCloneMethod.php
@@ -9,13 +9,26 @@
  */
 namespace PHPUnit\Framework\MockObject;
 
+use function version_compare;
+use PHPUnit\Event\Code\TestMethodBuilder;
+use PHPUnit\Event\Facade as EventFacade;
+
 /**
  * @internal This trait is not covered by the backward compatibility promise for PHPUnit
  */
 trait ProxiedCloneMethod
 {
     public function __clone(): void
     {
+        if (version_compare('8.3.0', PHP_VERSION, '>')) {
+            EventFacade::emitter()->testTriggeredPhpunitError(
+                TestMethodBuilder::fromCallStack(),
+                'Cloning test double objects requires PHP 8.3',
+            );
+
+            return;
+        }
+
         $this->__phpunit_state = clone $this->__phpunit_state;
 
         $this->__phpunit_state()->cloneInvocationHandler();

diff --git a/tests/unit/Framework/MockObject/MockObjectTest.php b/tests/unit/Framework/MockObject/MockObjectTest.php
@@ -14,6 +14,7 @@
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\IgnorePhpunitDeprecations;
 use PHPUnit\Framework\Attributes\Medium;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
@@ -443,6 +444,7 @@ public function testWillReturnCallbackWithVariadicVariables(): void
         $this->assertSame($testData, $actual);
     }
 
+    #[RequiresPhp('8.3')]
     public function testExpectationsAreClonedWhenTestDoubleIsCloned(): void
     {
         $double = $this->createMock(InterfaceWithReturnTypeDeclaration::class);

diff --git a/tests/unit/Framework/MockObject/TestDoubleTestCase.php b/tests/unit/Framework/MockObject/TestDoubleTestCase.php
@@ -11,6 +11,7 @@
 
 use Exception;
 use PHPUnit\Framework\Attributes\IgnorePhpunitDeprecations;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\TestFixture\MockObject\ExtendableClassWithCloneMethod;
@@ -240,6 +241,7 @@ final public function testMethodWithNeverReturnTypeDeclarationThrowsException():
     }
 
     #[TestDox('Original __clone() method is not called by default when test double object is cloned')]
+    #[RequiresPhp('8.3')]
     final public function testOriginalCloneMethodIsNotCalledByDefaultWhenTestDoubleObjectIsCloned(): void
     {
         $double = clone $this->createTestDouble(ExtendableClassWithCloneMethod::class);
@@ -248,6 +250,7 @@ final public function testOriginalCloneMethodIsNotCalledByDefaultWhenTestDoubleO
     }
 
     #[TestDox('Original __clone() method can optionally be called when test double object is cloned')]
+    #[RequiresPhp('8.3')]
     final public function testOriginalCloneMethodCanOptionallyBeCalledWhenTestDoubleObjectIsCloned(): void
     {
         $double = $this->getMockBuilder(ExtendableClassWithCloneMethod::class)->enableOriginalClone()->getMock();