Mocking an interface that extends another interface forgets to mock its own methods #3604

morozov · 2019-04-12T03:08:43Z

… mock its own methods

codecov · 2019-04-12T03:15:54Z

Codecov Report

Merging #3604 into 7.5 will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                7.5    #3604      +/-   ##
============================================
+ Coverage     83.41%   83.43%   +0.01%     
- Complexity     3632     3636       +4     
============================================
  Files           143      143              
  Lines          9671     9682      +11     
============================================
+ Hits           8067     8078      +11     
  Misses         1604     1604

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/MockObject/Generator.php	`88.3% <100%> (+0.3%)`	`137 <3> (+4)`	⬆️
src/Runner/Version.php	`66.66% <0%> (ø)`	`8% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29c052...db2e014. Read the comment docs.

sebastianbergmann · 2019-04-22T06:06:49Z

Thanks!

1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones. 2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent. 3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604 and sebastianbergmann/phpunit#3694.

1. Got rid of hard-coded exception mocks in favor of PHPUnit-generated ones where possible. 2. Reworked AbstractDriverTest::testConvertsException() to use a data provider to make testing all types of exceptions independent. 3. Updated PHPUnit since the reworked code relies on sebastianbergmann/phpunit#3604.

When mocking an interface that implements Throwable, do not forget to…

db2e014

… mock its own methods

morozov changed the title ~~When mocking an interface that implements Throwable, do not forget to …mock its own methods~~ When mocking an interface that implements Throwable, do not forget to mock its own methods Apr 12, 2019

sebastianbergmann merged commit 521aef9 into sebastianbergmann:7.5 Apr 22, 2019

sebastianbergmann changed the title ~~When mocking an interface that implements Throwable, do not forget to mock its own methods~~ Mocking an interface that extends another interface forgets to mock its own methods Apr 22, 2019

morozov deleted the issues/3596 branch April 22, 2019 16:40

snamor mentioned this pull request May 9, 2019

Regression in PHPUnit 7.5.10 with regard to Exception stubbing/mocking #3683

Closed

morozov mentioned this pull request May 16, 2019

Reworked driver exception tests doctrine/dbal#3546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mocking an interface that extends another interface forgets to mock its own methods #3604

Mocking an interface that extends another interface forgets to mock its own methods #3604

morozov commented Apr 12, 2019

codecov bot commented Apr 12, 2019 •

edited

Loading

sebastianbergmann commented Apr 22, 2019

Mocking an interface that extends another interface forgets to mock its own methods #3604

Mocking an interface that extends another interface forgets to mock its own methods #3604

Conversation

morozov commented Apr 12, 2019

codecov bot commented Apr 12, 2019 • edited Loading

Codecov Report

sebastianbergmann commented Apr 22, 2019

codecov bot commented Apr 12, 2019 •

edited

Loading