--log-events-text and --log-events-verbose-text CLI options do not handle absolute and relative paths
#5633
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marac19901990
changed the title
sebastianbergmann
force-pushed
the
10.5-resolve-relative-path
branch
from
d8ed303 to
a63b6ec
Compare
sebastianbergmann
added
type/bug
tests/end-to-end/cli/log-events-verbose-text-invalid-argument.phpt
Outdated
Show resolved
Hide resolved
tests/end-to-end/cli/log-events-verbose-text-invalid-argument.phpt
Outdated
Show resolved
Hide resolved
sebastianbergmann
changed the title
--log-events-text and --log-events-verbose-text CLI options do not handle absolute and relative paths
sebastianbergmann
removed
the
feature/events
tests/end-to-end/cli/log-events-verbose-text-invalid-argument.phpt
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 10.5 #5633 +/- ##
=========================================
Coverage 89.40% 89.41%
- Complexity 6408 6410 +2
=========================================
Files 682 682
Lines 20383 20391 +8
=========================================
+ Hits 18224 18232 +8
Misses 2159 2159 ☔ View full report in Codecov by Sentry. |
sebastianbergmann
force-pushed
the
10.5-resolve-relative-path
branch
from
47e7b60 to
1b248a3
Compare
|
Thanks! |
|
I just noticed that this breaks Values given for @marac19901990 Can you please have a look at this? Thanks! |
|
@marac19901990 Nevermind, I think I have a patch ready. |
sebastianbergmann
added a commit
that referenced
this pull request
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve both relative and absolute paths, and handle invalid arguments.