Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making peer dependencies less strict #303

Closed
thetutlage opened this issue Jul 20, 2021 · 3 comments
Closed

Making peer dependencies less strict #303

thetutlage opened this issue Jul 20, 2021 · 3 comments

Comments

@thetutlage
Copy link

thetutlage commented Jul 20, 2021

The peerDependencies defined in the package.json file https://github.com/sebbo2002/ical-generator/blob/develop/package.json#L68-L70 are a little more strict than they really have to be.

For example: I cannot use ical-generator with types from Node16 as the range defined is ^15.0.3. Same is true with luxon.

Shouldn't we change them to accept anything greater than the supported version >= 15.0.3?


I am using npm version 7.19.1

@sebbo2002 sebbo2002 self-assigned this Jul 21, 2021
@sebbo2002 sebbo2002 added the bug label Jul 21, 2021
@sebbo2002
Copy link
Owner

You are absolutely right. I hope to find time to do it this week, I hope it's not time-critical.

@github-actions github-actions bot mentioned this issue Jul 22, 2021
github-actions bot pushed a commit that referenced this issue Jul 22, 2021
# [3.0.0-develop.4](v3.0.0-develop.3...v3.0.0-develop.4) (2021-07-22)

### Bug Fixes

* Make peerDependencies less strict ([1c3a8f2](1c3a8f2)), closes [#303](#303)
@sebbo2002
Copy link
Owner

🎉 This issue has been resolved in version 3.0.0-develop.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thetutlage
Copy link
Author

Thanks :)

github-actions bot pushed a commit that referenced this issue Jul 31, 2021
# [3.0.0](v2.2.0...v3.0.0) (2021-07-31)

### Bug Fixes

* Make peerDependencies less strict ([1c3a8f2](1c3a8f2)), closes [#303](#303)

### chore

* Remove node.js 10 Support ([2b910c0](2b910c0))

### BREAKING CHANGES

* Removed support for node.js v10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants