Update to enable offline sniff() to use a PacketList (#3026)

secdev · Jan 14, 2021 · ef4937f · ef4937f
1 parent a436560
commit ef4937f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/scapy/sendrecv.py b/scapy/sendrecv.py
@@ -887,7 +887,7 @@ def _write_to_pcap(packets_list):
 
                 if isinstance(offline, Packet):
                     tempfile_written, offline = _write_to_pcap([offline])
-                elif isinstance(offline, list) and \
+                elif isinstance(offline, (list, PacketList)) and \
                         all(isinstance(elt, Packet) for elt in offline):
                     tempfile_written, offline = _write_to_pcap(offline)
 

diff --git a/test/regression.uts b/test/regression.uts
@@ -1864,6 +1864,11 @@ fdesc = os.fdopen(fdesc, "wb")
 wrpcap(fdesc, pktpcap)
 fdesc.close()
 
+= Check offline sniff() (by PacketList)
+l=sniff(offline=PacketList([IP()/TCP(),IP()/TCP()]))
+assert len(l) == 2
+assert(all(TCP in p for p in l))
+
 = Check offline sniff() (by filename)
 assert list(pktpcap) == list(sniff(offline=filename))