Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected to use packet_list function argument #3053

Closed
wants to merge 1 commit into from

Conversation

piersoh
Copy link
Contributor

@piersoh piersoh commented Jan 14, 2021

Minor correction so that the internal _write_to_pcap function uses its argument packet_list when calling wrpcap(filename, packets_list) as opposed to the outer scope offline variable.

@gpotter2
Copy link
Member

Thanks for the PR. This makes sense, however this will conflict with #3055 (we've ended up refactoring the whole thing).

Maintainers, please do not merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants