Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check #4528

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 6, 2024

@gpotter2 gpotter2 added the cleanup Performs some code clean-up label Sep 6, 2024
@gpotter2 gpotter2 added this to the 2.6.0 milestone Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.58%. Comparing base (a51bcd5) to head (0132ed0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4528      +/-   ##
==========================================
+ Coverage   81.36%   81.58%   +0.22%     
==========================================
  Files         356      356              
  Lines       85277    85277              
==========================================
+ Hits        69387    69575     +188     
+ Misses      15890    15702     -188     
Files with missing lines Coverage Δ
scapy/arch/linux/__init__.py 82.88% <ø> (+0.24%) ⬆️

... and 18 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 867f92a into secdev:master Sep 7, 2024
24 checks passed
@gpotter2 gpotter2 deleted the regress-check-useless branch September 7, 2024 13:50
@polybassa
Copy link
Contributor

Do you think it makes sense to have a quick test like

set interface down
conf.ifaces.reload()
set interface up
sniff(...)

@gpotter2
Copy link
Member Author

gpotter2 commented Sep 7, 2024

It's probably alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Performs some code clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to set promiscuous mode on interface after #4497
2 participants