This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Improve performance of creating access rules #236
Merged
Merged
Commits on Mar 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 98acf22 - Browse repository at this point
Copy the full SHA 98acf22View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3adf78 - Browse repository at this point
Copy the full SHA a3adf78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5263470 - Browse repository at this point
Copy the full SHA 5263470View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3a3386 - Browse repository at this point
Copy the full SHA f3a3386View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6230285 - Browse repository at this point
Copy the full SHA 6230285View commit details
Commits on Apr 1, 2021
-
Refactor testcase to use format used through the repo
Changing naming and test struct format to be consistent throughout the repository.
Configuration menu - View commit details
-
Copy full SHA for 4ee9cae - Browse repository at this point
Copy the full SHA 4ee9caeView commit details -
Fix: don't continue test on error
Just printing the error isn't sufficient. In case of an error in these situations, we shouldn't continue, as it results in a nil-pointer derference.
Configuration menu - View commit details
-
Copy full SHA for 254bb27 - Browse repository at this point
Copy the full SHA 254bb27View commit details -
Fix: isolate cases in separate testcases
Separating testcases like this gives lots of benefits: - When a test fails, the name of the case that fails is given. - Test reports show all cases ran - When one case fails, the others are still also ran, to see if they succeed.
Configuration menu - View commit details
-
Copy full SHA for 33318b5 - Browse repository at this point
Copy the full SHA 33318b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a10743e - Browse repository at this point
Copy the full SHA a10743eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec7b4a4 - Browse repository at this point
Copy the full SHA ec7b4a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.