Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Account delete #237

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Account delete #237

merged 2 commits into from
Aug 19, 2021

Conversation

Marton6
Copy link
Member

@Marton6 Marton6 commented Mar 31, 2021

This PR adds a Delete method to the account service, that deletes the currently authenticated account.

To prevent users from calling this method accidentally, the method requires you to pass your own account id as parameter.

@Marton6 Marton6 changed the title Feature/account delete Account delete Mar 31, 2021
@Marton6 Marton6 changed the base branch from master to develop March 31, 2021 12:12
@Marton6 Marton6 marked this pull request as ready for review April 16, 2021 11:31
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good 👍

We should wait with merging this until server-side changes are released.

@SimonBarendse SimonBarendse merged commit e5c3f00 into develop Aug 19, 2021
@SimonBarendse SimonBarendse deleted the feature/account-delete branch August 19, 2021 15:38
@SimonBarendse SimonBarendse mentioned this pull request Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants