Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Support for deleting secrets #12

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Support for deleting secrets #12

merged 4 commits into from
Mar 28, 2019

Conversation

florisvdg
Copy link
Member

On the /secrets/raw route. Because it's on /raw it deletes the entire secret.

SimonBarendse
SimonBarendse reviewed Mar 19, 2019
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried supplying a path that contains a version? What happens in that case?

pkg/restproxy/rest_proxy.go Show resolved Hide resolved
SimonBarendse
SimonBarendse reviewed Mar 19, 2019
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes to keep us DRY 👍

Have you tried supplying a path that contains a version? What happens in that case?

Have you tried this yet?

SimonBarendse
SimonBarendse approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@florisvdg
Copy link
Member Author

Made a delete only delete the specified version for now, instead of deleting the entire secret and its history.

@florisvdg florisvdg merged commit 1540e6f into develop Mar 28, 2019
@florisvdg florisvdg deleted the delete-secret branch March 28, 2019 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonBarendse SimonBarendse SimonBarendse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florisvdg @SimonBarendse