Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Add passphrase fallback prompt #16

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Add passphrase fallback prompt #16

merged 3 commits into from
Apr 5, 2019

Conversation

florisvdg
Copy link
Member

Simple support to avoid the passphrase potentially showing up in the command history

mackenbach
mackenbach suggested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work. However, there are some points that require a bit more attention.

cmd/secrethub-http-proxy/main.go Show resolved Hide resolved
cmd/secrethub-http-proxy/main.go Outdated Show resolved Hide resolved
cmd/secrethub-http-proxy/main.go Outdated Show resolved Hide resolved
mackenbach
mackenbach approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This makes it already a lot more usable to people that have their credential protected with a passphrase (which I would say they should by default)

@florisvdg florisvdg merged commit 50a7d15 into develop Apr 5, 2019
@florisvdg florisvdg deleted the feature/passphrase-prompt branch April 5, 2019 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonBarendse SimonBarendse SimonBarendse left review comments

@mackenbach mackenbach mackenbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florisvdg @mackenbach @SimonBarendse