Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI badges #673

Merged
merged 10 commits into from
Jan 11, 2023
Merged

CI badges #673

merged 10 commits into from
Jan 11, 2023

Conversation

itrushkin
Copy link
Contributor

@itrushkin itrushkin commented Jan 5, 2023 •
edited
Loading

New

  • Ubuntu test sequence
  • Windows test sequence
  • 2 badges in the README.md

The test sequence for both operating systems is following:

@itrushkin itrushkin changed the title CI badges WIP: CI badges Jan 5, 2023
@itrushkin
Introduce test sequences for ubuntu/windows
3a18db9 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Create badges
95a4ba1 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix workflow syntax
c995024 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove table draft
df1f9d4 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Copy link
Contributor Author

Badges could not be rendered. According to Github documentation, scheduled workflows will trigger only after workflow files appear in the default (develop) branch. In order for badges to render, this PR should be merged. Both workflows have been tested locally.

@itrushkin itrushkin changed the title WIP: CI badges CI badges Jan 9, 2023
@itrushkin
Remove OS environment variable
25d3987 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Test workflows on GitHub runners
05bef71 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove linter step on Windows
6c7c7bb 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove lint job from dependencies on Windows
b2cee4c 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove dockerization test for Windows
ac251a0 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Copy link
Contributor Author

itrushkin commented Jan 10, 2023 •
edited
Loading

Badges in this branch have been rendered. Resetting the trigger to scheduled.

@itrushkin
Return schedule trigger
8978e28 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@psfoley psfoley self-requested a review January 11, 2023 00:00
psfoley
psfoley approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@psfoley psfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psfoley psfoley merged commit b1e1d39 into develop Jan 11, 2023
@psfoley psfoley mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfoley psfoley psfoley approved these changes

@aleksandr-mokrov aleksandr-mokrov Awaiting requested review from aleksandr-mokrov

@igor-davidyuk igor-davidyuk Awaiting requested review from igor-davidyuk

@mansishr mansishr Awaiting requested review from mansishr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itrushkin @psfoley