Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversion overflow false positive when value is explicitly checked #1193

Closed
wants to merge 1 commit into from
Closed

Fix conversion overflow false positive when value is explicitly checked #1193

wants to merge 1 commit into from

Conversation

ben-krieger
Copy link
Contributor

Fixes #1187

TO DO:

  • Iterate blocks backwards to exclude checks performed after the conversion?
  • Validate comparisons ensure proper bounds?
  • Allow for equality comparisons?

@ben-krieger ben-krieger mentioned this pull request Aug 27, 2024
Merged
@ben-krieger
Copy link
Contributor Author

Closing in favor of #1194.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

G115 ignores bounds checks
1 participant
@ben-krieger