Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[midstream-v2.1.1] add patch file for validate-release job #11

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #10

/assign lance

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a securesign member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance
Copy link
Member

lance commented Sep 15, 2023

/ok-to-test

Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance
Copy link
Member

lance commented Sep 18, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, lance, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member

lance commented Sep 18, 2023

Going to try closing and reopening now that openshift-cherrypick-robot has access to see if CI will run

@lance lance closed this Sep 18, 2023
@lance lance reopened this Sep 18, 2023
@lance
Copy link
Member

lance commented Sep 18, 2023

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

@lance: No presubmit jobs available for securesign/cosign@midstream-v2.1.1

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JasonPowr
Copy link

@lance should I manually open a pr, with these changes ?

@lance
Copy link
Member

lance commented Sep 18, 2023

@JasonPowr I have been chatting with OCP testplatform and RHTAP folks. Let's see if we can get it figured out there. If not, that probably makes sense.

@lance
Copy link
Member

lance commented Sep 18, 2023

@JasonPowr after all of that, it's clear why pipelines aren't running on this PR. We are merging onto the midstream branch which doesn't contain the .tekton directory - so pipelines cannot and should not run.

@lance lance merged commit ec9ad83 into securesign:midstream-v2.1.1 Sep 18, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants