Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rhtap references #9

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

red-hat-konflux[bot]
Copy link

This PR contains the following updates:

Package Change Notes
quay.io/redhat-appstudio-tekton-catalog/task-buildah ebbf385 -> e607665
quay.io/redhat-appstudio-tekton-catalog/task-deprecated-image-check 0.2 -> 0.3 ⚠️migration⚠️

To execute skipped test pipelines write comment /ok-to-test

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-trusted-app-pipeline[bot]
Once this PR has been reviewed and has the lgtm label, please assign lance for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

Hi @red-hat-trusted-app-pipeline[bot]. Thanks for your PR.

I'm waiting for a securesign member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JasonPowr
Copy link

I noticed that CI-Validate-Release-Job / validate-release-job (pull_request) job was failing after some investigation I found this pr in the upstream repos that supposedly fixes this issue, sigstore#3169 However this doesn't seem to be present in our midstream repos. Im just wondering if theres an issue with the sync script it doesnt seem to have picked up these changes, should this be manually added? @lance

Signed-off-by: Jason Power <japower@redhat.com>
Signed-off-by: Jason Power <japower@redhat.com>
@red-hat-konflux
Copy link
Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@lance
Copy link
Member

lance commented Sep 12, 2023

@JasonPowr that commit landed in upstream v2.2.0 which was released two weeks ago. We are currently tracking 2.1.1. Odd that the change is causing the 2.1.1 line to fail.

One option would be to just create a midstream-v2.2.0 branch and start tracking the new release, however, the new release bumps the golang version to 1.21 which we don't have a builder image for yet, to my knowledge.

@lance lance merged commit 3511473 into redhat-v2.1.1 Sep 18, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants