HM24 Proto Definition Concepts #1711
Conversation
| string document_id = 2; | ||
|
|
||
| // the path of the document which is being updated. may include slashes to represent a deep index | ||
| string path = 3; |
There was a problem hiding this comment.
Do we allow paths to have slashes? I thought we wanted to represent deep hierarchies with multiple documents and their corresponding indexes?
Can an index entry for a single document have slashes?
There was a problem hiding this comment.
in my understanding, index key may not contain slashes.
when you use a path with a slash, you refer to the index of an index
There was a problem hiding this comment.
OK, same for me. Maybe I misunderstood the comment then.
/ the path of the document which is being updated. may include slashes to represent a deep index
In what cases can this be a nested path then?
Also, it says "document which is being updated", but this Branch struct only seems to be used in a ListDocumentBranches request which doesn't update anything.
There was a problem hiding this comment.
Say document A has a static index key 'b' of document B, who has a static index key 'c' of document C.
If the user is looking at document A/b/c (with a URL like hm://DOC_A_ID/b/c) and they click edit, a new branch will be created. The branch will have document_id=DOC_A_ID and path of b/c.
When the branch is published, a new change will be created for Doc C, and a new change will be created for Doc B which updates the index to the new version of Doc C. And a new change will be created for Doc A which updates the index to the new version of Doc B.
I know this is complex and does not need to be immediately supported. But does that make sense, at least?
There was a problem hiding this comment.
I thought last time we discussed it we said that when I'm looking at a document on hm://<some-namespace-document>/foo/bar/baz which points to some changes who all have common root (or genesis) change QmC1, and then you press "Edit", you are not editing the <some-namespace-document> but rather the document foo/bar/baz points to.
There was a problem hiding this comment.
Yes you are! But it will be saved to the parent or grandparent doc, so the draft reflects that information
|
🔥 |
Here are some ideas on how the new document entity can be augmented. This is still a WIP, but it is enough to start the discussion